Caching ongoing GetConversationById requests to not do them twice#1208
Merged
WojcikMike merged 2 commits intomasterfrom May 31, 2022
Merged
Caching ongoing GetConversationById requests to not do them twice#1208WojcikMike merged 2 commits intomasterfrom
WojcikMike merged 2 commits intomasterfrom
Conversation
mauroservienti
approved these changes
May 27, 2022
Co-authored-by: Mauro Servienti <mauro.servienti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current controls displaying Flow Diagram and Sequence diagram do the same call to GetConversationById. This change records the ongoing check and when other control wants to ask for the same conversation it returns the same value.