[API Compatibility No.359] param alias for deg2rad -part#77168
Merged
zhwesky2010 merged 15 commits intoPaddlePaddle:developfrom Jan 22, 2026
Merged
[API Compatibility No.359] param alias for deg2rad -part#77168zhwesky2010 merged 15 commits intoPaddlePaddle:developfrom
zhwesky2010 merged 15 commits intoPaddlePaddle:developfrom
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Removed commented-out implementation and documentation for the tangent operator.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #77168 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 1
Lines ? 3
Branches ? 0
===========================================
Hits ? 3
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/re-run all-failed |
Manfredss
changed the title
zhwesky2010
reviewed
Jan 7, 2026
python/paddle/tensor/math.py
Outdated
| if in_dynamic_or_pir_mode(): | ||
| if convert_dtype(x.dtype) in ['int32', 'int64']: | ||
| x = cast(x, dtype="float32") | ||
| if out is not None: |
Contributor
There was a problem hiding this comment.
_C_ops会自动处理out=None的情况，无需再额外判断，直接透传。
| args_mapper : | ||
| func : ArgSumMapper | ||
|
|
||
| - op : tan |
Contributor
There was a problem hiding this comment.
tan已经下沉了，这个PR不用再改了。只用修改deg2rad即可。
Contributor
|
看看CI问题 |
… ApiEnhance361_378
zhwesky2010
reviewed
Jan 13, 2026
python/paddle/tensor/math.py
Outdated
| x = cast(x, dtype="float32") | ||
| return _C_ops.scale(x, deg2rad_scale, 0.0, True) | ||
| _C_ops.scale(x, deg2rad_scale, 0.0, True, out=out) | ||
| return out |
Contributor
There was a problem hiding this comment.
这个return看起来不太对？直接return _C_ops.scale(x, deg2rad_scale, 0.0, True, out=out)
zhwesky2010
changed the title
… ApiEnhance361_378
|
|
Contributor
Author
|
/re-run all-failed |
zhwesky2010
reviewed
Jan 15, 2026
python/paddle/tensor/math.py
Outdated
| if convert_dtype(x.dtype) in ['int32', 'int64']: | ||
| x = cast(x, dtype="float32") | ||
| return _C_ops.scale(x, deg2rad_scale, 0.0, True) | ||
| if in_pir_mode(): |
Contributor
There was a problem hiding this comment.
不用区分pir了，dygraph测out就行。
这里直接：return _C_ops.scale(x, deg2rad_scale, 0.0, True, out=out)
test/legacy_test/test_deg2rad.py
Outdated
|
|
||
| # Test out | ||
| out = paddle.zeros([1], dtype="float32") | ||
| res = paddle.deg2rad(x, out=out) |
… ApiEnhance361_378
zhwesky2010
reviewed
Jan 19, 2026
test/legacy_test/test_deg2rad.py
Outdated
| import os | ||
| import unittest | ||
|
|
||
| os.environ['FLAGS_enable_pir_api'] = '0' |
zhwesky2010
reviewed
Jan 19, 2026
test/legacy_test/test_deg2rad.py
Outdated
| with paddle.static.program_guard(startup_program, train_program): | ||
| x = paddle.static.data(name='input', dtype='float32', shape=[1]) | ||
| out = paddle.static.data(name='out', dtype='float32', shape=[1]) | ||
| result = paddle.deg2rad(x, out=out) |
Contributor
There was a problem hiding this comment.
静态图下你可以测下别名其他这些，out不用测
Manfredss
changed the title
… ApiEnhance361_378
… ApiEnhance361_378
… ApiEnhance361_378
Contributor
Author
|
/re-run all-failed |
zhwesky2010
approved these changes
Jan 21, 2026
SigureMo
approved these changes
Jan 21, 2026
xunyoyo
pushed a commit
to xunyoyo/Paddle
that referenced
this pull request
Jan 28, 2026
…e#77168) * cpp sink for tan, param alias for deg2rad * Remove commented-out tan function and its documentation Removed commented-out implementation and documentation for the tangent operator. * Refactor deg2rad function to simplify output handling * Update Python API information in yaml file * fix * increase coverage * fix tests for deg2rad * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
add param alias for paddle.deg2rad