forked from quisquous/cactbot
-
Notifications
You must be signed in to change notification settings - Fork 73
Open
Labels
enhancementNew feature or change to existing functionalityNew feature or change to existing functionalityneeds-reviewAwaiting reviewAwaiting review
Description
Feature(s) Requested
Just a thought I had while working on some timeline branches.
Two lines in a row with uncommented forcejump should result in a test or lint failure since this would indicate unreachable code exists in the timeline. A forcejump would skip over the subsequent forcejump line regardless of sync.
In my situation the correction was to use jump instead for the first forcejump, and then next either jump or forcejump could be used to skip over the lookahead:
Example:
50496.3 "--sync--" StartsUsing { id: "7602", source: "Marble Dragon" } forcejumo "oc-md-p2o"
50496.3 "--sync--" StartsUsing { id: "7614", source: "Marble Dragon" } forcejump "oc-md-p2+"
50497.3 "Imitation Blizzard (circles/crosses?)" #Ability { id: "7602", source: "Marble Dragon" }
Should warn/error for this as. Hinting for use of jump is an added bonus:
For instance:
Warning: Use of forcejump on multiple lines in a row leads to unreachable code, use jump instead:
50496.3 "--sync--" StartsUsing { id: "7602", source: "Marble Dragon" } jump 50795.7
50496.3 "--sync--" StartsUsing { id: "7614", source: "Marble Dragon" } forcejump "oc-md-p2+"
50497.3 "Imitation Blizzard (circles/crosses?)" #Ability { id: "7602", source: "Marble Dragon" }
Metadata
Metadata
Assignees
Labels
enhancementNew feature or change to existing functionalityNew feature or change to existing functionalityneeds-reviewAwaiting reviewAwaiting review