Skip to content

Conversation

@stellaprins
Copy link
Collaborator

@stellaprins stellaprins commented Jan 14, 2025

addresses #103 and updates detailed biomodels compatibility tables

@stellaprins stellaprins requested a review from robertvi January 14, 2025 12:04
@stellaprins stellaprins marked this pull request as ready for review January 14, 2025 12:10
Copy link
Collaborator

@robertvi robertvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to check that you intend the omex files to be checked into the repo?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: space in file name might cause issues if the filename is ever run through a shell command without enclosing quotes

@stellaprins
Copy link
Collaborator Author

Just wanted to check that you intend the omex files to be checked into the repo?

Yep, @pgleeson asked me to commit the omex files so that it is easy for others to use them.

note: space in file name might cause issues if the filename is ever run through a shell command without enclosing quotes

Yep, that omex file is saved using the original name (with a space) an ammended name (space replaced by underscore). The latter is used for submission to tellurium natively to prevent shell command issues.

@stellaprins stellaprins merged commit 2dc0312 into development Jan 20, 2025
24 checks passed
@stellaprins stellaprins deleted the feat-biomodels branch January 20, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants