Feature - Load Balancer Round Robin Queue for Destination Selection#1036
Open
ryleyd wants to merge 4 commits intoOpenSIPS:masterfrom
Open
Feature - Load Balancer Round Robin Queue for Destination Selection#1036ryleyd wants to merge 4 commits intoOpenSIPS:masterfrom
ryleyd wants to merge 4 commits intoOpenSIPS:masterfrom
Conversation
Author
|
Hey are there any additional changes/steps that I need to do? I was hoping to get some more feedback on this pull request. |
liviuchircu
reviewed
Aug 3, 2017
| //Find lowest queue number in virtual queue | ||
| q_lowest = data->dst_no; | ||
| for( i=0 ; i<dsts_size_cur; i++){ | ||
| if (dsts[i]->queue_loc < q_lowest){ |
Member
There was a problem hiding this comment.
Harmless in this case, but for code consistency, this should be dsts_cur[i]->queue_loc, as below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting the addition of a new destination selection method for load balancer module. Organizes a virtual queue for destinations and uses this information to select destinations on a round robin basis (in order to balance load when selections are staggered and not simultaneous). Raising new flag 'q' at load balance start will modify selection to use this information.
This feature is used to fulfill a customer requirement to utilize the least used resource during balance selection.
Additional fixes include bug fix to group selection (using -1 for all was not working) and spelling fix in one location.