Skip to content

fix: correct log messages in KokoroTTSProvider from ElevenLabs to Kokoro#2151

Open
giwaov wants to merge 1 commit intoOpenMind:mainfrom
giwaov:fix/kokoro-tts-log-messages
Open

fix: correct log messages in KokoroTTSProvider from ElevenLabs to Kokoro#2151
giwaov wants to merge 1 commit intoOpenMind:mainfrom
giwaov:fix/kokoro-tts-log-messages

Conversation

@giwaov
Copy link

@giwaov giwaov commented Feb 7, 2026

Problem

The KokoroTTSProvider class in src/providers/kokoro_tts_provider.py has incorrect log messages that reference 'Eleven Labs TTS provider' instead of 'Kokoro TTS provider'. This is a copy-paste error from when the class was created based on the ElevenLabsTTSProvider.

Affected Code

Line 211 (start method):

logging.warning("Eleven Labs TTS provider is already running")

Line 222 (stop method):

logging.warning("Eleven Labs TTS provider is not running")

Impact

  • Debugging confusion: When developers see 'Eleven Labs TTS provider is already running' in logs but are configuring Kokoro TTS, it creates confusion
  • Incorrect diagnostics: Users may troubleshoot the wrong provider based on misleading log messages
  • Code maintenance: Future developers may not realize which provider is actually being used

Solution

Changed the log messages to correctly reference 'Kokoro TTS provider':

# Before
logging.warning("Eleven Labs TTS provider is already running")
logging.warning("Eleven Labs TTS provider is not running")

# After
logging.warning("Kokoro TTS provider is already running")
logging.warning("Kokoro TTS provider is not running")

Testing

  • Existing tests in tests/providers/test_kokoro_tts_provider.py continue to pass
  • Tests verify 'already running' and 'is not running' patterns which are preserved
  • No behavioral changes, only log message text corrections

The start() and stop() methods in KokoroTTSProvider incorrectly
referenced 'Eleven Labs TTS provider' in their log messages.
This was a copy-paste error from the ElevenLabsTTSProvider.

Corrected the log messages to properly reference 'Kokoro TTS provider'
for accurate debugging and logging.
@giwaov giwaov requested a review from a team as a code owner February 7, 2026 14:03
Copilot AI review requested due to automatic review settings February 7, 2026 14:03
@giwaov giwaov requested a review from a team as a code owner February 7, 2026 14:03
@github-actions github-actions bot added robotics Robotics code changes python Python code labels Feb 7, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes misleading lifecycle warning log messages in KokoroTTSProvider so they correctly refer to Kokoro (not Eleven Labs), aligning runtime logs with the configured provider.

Changes:

  • Update the start() “already running” warning to reference “Kokoro TTS provider”.
  • Update the stop() “not running” warning to reference “Kokoro TTS provider”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Python code robotics Robotics code changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants