fix: fix infinite busy-loop in RPLidar _read_response on device disconnect#2144
Open
andrewshab3 wants to merge 5 commits intoOpenMind:mainfrom
Open
fix: fix infinite busy-loop in RPLidar _read_response on device disconnect#2144andrewshab3 wants to merge 5 commits intoOpenMind:mainfrom
andrewshab3 wants to merge 5 commits intoOpenMind:mainfrom
Conversation
Collaborator
|
Hi @andrewshab3 , Thanks for contribution ! Could you add unit tests for the new behavior |
Added tests for RPLidar driver response handling, including timeout and device disconnection scenarios.
Author
Done, thanks! |
Collaborator
please fix error |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Wanbogang
approved these changes
Feb 7, 2026
0xbyt4
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Changes
Checklist