Fix: RPLidar angle blanking has no effect due to continue in nested loop#2139
Open
letmehateu wants to merge 3 commits intoOpenMind:mainfrom
Open
Fix: RPLidar angle blanking has no effect due to continue in nested loop#2139letmehateu wants to merge 3 commits intoOpenMind:mainfrom
letmehateu wants to merge 3 commits intoOpenMind:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
0xbyt4
approved these changes
Feb 6, 2026
5 tasks
Collaborator
|
Hi @letmehateu |
0xbyt4
requested changes
Feb 6, 2026
Collaborator
0xbyt4
left a comment
There was a problem hiding this comment.
Tests pass on the buggy code too , test angles don't fall within blanked ranges after sensor_mounting_angle conversion. Please fix test data.
Author
Thanks, should work properly now |
Collaborator
|
@letmehateu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
[Provide a brief overview of the changes in this pull request.]
(If applicable, linked issue: [ ])
Type of change
Changes
Checklist
Impact
Any robot with non-empty angles_blanked config (Turtlebot4, test_lidar, etc.) was affected. Fixed reflections from the chassis were treated as real obstacles, potentially causing unnecessary stops or evasive manoeuvres.
FIxed: #2138