Skip to content

test(actions): add unit tests for emotion action#2129

Closed
LupaFlex wants to merge 1 commit intoOpenMind:mainfrom
LupaFlex:test/add-emotion-action-tests
Closed

test(actions): add unit tests for emotion action#2129
LupaFlex wants to merge 1 commit intoOpenMind:mainfrom
LupaFlex:test/add-emotion-action-tests

Conversation

@LupaFlex
Copy link

@LupaFlex LupaFlex commented Feb 5, 2026

Summary

Added comprehensive unit tests for the emotion action module which previously had no test coverage.

Changes

  • tests/actions/emotion/test_interface.py: Tests for EmotionAction enum, EmotionInput dataclass, and Emotion interface
  • tests/actions/emotion/connector/test_unitree_sdk.py: Tests for EmotionUnitreeConfig and EmotionUnitreeConnector

Test Coverage

  • EmotionAction enum values and type validation
  • EmotionInput creation with all action types
  • Emotion interface with input/output handling
  • EmotionUnitreeConfig default and custom values
  • EmotionUnitreeConnector initialization with/without ethernet
  • LED control for all emotions (happy, sad, mad, curious)
  • Tick method behavior

Testing

  • All 17 tests pass
  • Pre-commit checks pass
  • Ruff linting passes

@LupaFlex LupaFlex requested a review from a team as a code owner February 5, 2026 20:15
@github-actions github-actions bot added python Python code tests Test files labels Feb 5, 2026
@0xbyt4
Copy link
Collaborator

0xbyt4 commented Feb 5, 2026

hi @LupaFlex Thanks for adding test coverage for the emotion action! Some adjustments needed to match existing patterns Please check carefully .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Python code tests Test files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants