V2 #1
Draft
V2 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify Connection's destructor so that it doesn't fire propagateEmptyData without an output node connected to it previously.
- added NodeDataModel::portInConnectionPolicy (similar to NodeDataModel::portOutConnectionPolicy) - added a new parameter to NodeDataModel::setInData representing the respective connection - modified NodeConnectionInteraction::disconnect to only erase one connection from the port rather than clear all connections
Signed-off-by: Yadunund <yadunund@gmail.com>
GraphicsScene knows already how to select the items when various mouse events occur. We do not need to manually implement the behavior of the CTRL key for selecting/deselecting the items. One thing let to fix was explicit deselection of all the items when the current item is started being moved by the mouse.
* without this forward declaration it it wasn't compilling * Update NodeDataModel.hpp Co-authored-by: tatolevicz <leviczios@gmail.com> Co-authored-by: Dmitry Pinaev <dimitry.pinaev@gmail.com>
The original idea was to be able to include the NodeEditor library to some super-project along with the included Catch2 (also as a subprobject), i.e.: ``` add_subdirectory(catch2) add_subdirectory(NodeEditor) ``` To do this we need to detect inside NodeEditor's CMake scripts whether the Catch2 target was already included. If not, we included our own Catch2 subdirectory. The chosen names of the macro caused recursion when called from within vcpkg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.