cache ResultSet metadata in getMetaDataMapByMessageId to reduce per-row metadata lookups#282
Merged
NicoPiel merged 6 commits intoOpenIntegrationEngine:mainfrom Apr 2, 2026
Conversation
NicoPiel
force-pushed
the
feat/jdbc-metadata-perf
branch
from
1aa2ec3 to
e778f04
Compare
mgaffigan
requested changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
I doubt this is making actual round-trips, but unopposed to cleaning things up. At a minimum, we should drop some GC pressure from the repeated toUpperCase and fromSqlType.
Also: consider whether the move to 0-indexing is actually adding value. For the cost of two empty array elements, this PR gets a lot smaller and there's less opportunity to screw up the zero-based vs one-based indexing.
Also: missing DCO
donkey/src/main/java/com/mirth/connect/donkey/server/data/jdbc/JdbcDao.java
Outdated
Show resolved
Hide resolved
…ow metadata lookups Cache ResultSetMetaData (column count, types, and names) before iterating rows so getColumnType/getColumnName are not called for every row. Adjust column indexing and decryption logging to use the cached metadata. This reduces repeated metadata calls and improves performance when reading connector metadata from the database. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Cache ResultSetMetaData (column count, types, and names) up front instead of calling getColumnType/getColumnName for every row. This reduces repeated metadata lookups and improves performance when reading metadata rows from the database. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
…tadata lookups Cache ResultSetMetaData (column count, types, and names) before iterating rows and switch to 1-based arrays/loops so resultSet getters can be called directly with the column index. This prevents repeated getColumnType/getColumnName calls for every row and reduces per-row metadata lookups when building connector metadata maps. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
force-pushed
the
feat/jdbc-metadata-perf
branch
from
311b9d8 to
b385fd4
Compare
Collaborator
Author
|
Followed your suggestions and added DCO |
NicoPiel
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
mgaffigan,
pacmano1,
ssrowe and
tonygermano
and removed request for
a team
mgaffigan
approved these changes
Mar 31, 2026
jonbartels
approved these changes
Mar 31, 2026
Contributor
jonbartels
left a comment
jonbartels
left a comment
There was a problem hiding this comment.
I also did some digging to find out if this is a DB hit or something else. It reduces 1000s of calls to only one call per column. Its a good change. Great find Nico!
kryskool
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache ResultSetMetaData (column count, types, and names) before iterating rows so getColumnType/getColumnName are not called for every row. Adjust column indexing and decryption logging to use the cached metadata. This reduces repeated metadata calls and improves performance when reading connector metadata from the database.