More useful message for NO_DEFAULT exception out of the box. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saintf
reviewed
Jul 25, 2019
| /** | ||
| * For backward compatibility. | ||
| */ | ||
| @Deprecated |
Collaborator
There was a problem hiding this comment.
Why not straight out delete it? Just wondering if anyone outside of the annotation-error-decoder actually explicitly uses NO_DEFAULT... (which would be weird to me)
Contributor
Author
There was a problem hiding this comment.
No problem. I wasn't sure about the policy of introducing breaking changes. Removed this constructor entirely.
Collaborator
|
The build seems to have failed because of formatting - can you check on the build if files get modified (so that you can get them to do proper formatting and the build won't fail?)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a misconfigured error happens, NO_DEFAULT exception gives no clue on what went wrong. You have to always provide more meaningful default. This change will at least make sure you know what status response had when on the moment of error.