Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponds with OpenFAST/openfast#2334
Updates to the MoorDyn-F body and rod kinematics to include centripetal forces and moments broke the tests that were looking at kinematics. These have been updated now with new values.
md_float now has a different pitch decay than before, still arriving at the same equilibrium
md_BodiesAndRods had minor differences in fairlead tensions causing brief error spikes but behavior was still the same
md_lineFail had the coupled point location at 1, 0, 0 but the driver was passing 0, 0, 0. Not sure how this didn't cause issues before but the files have been adjusted accordingly. The output files have also been updated and checked that behavior is still as expected.