Skip to content

Documentation for ExtPtfm#858

Merged
ebranlard merged 2 commits intoOpenFAST:devfrom
ebranlard:f/extptfm-doc
Oct 15, 2021
Merged

Documentation for ExtPtfm#858
ebranlard merged 2 commits intoOpenFAST:devfrom
ebranlard:f/extptfm-doc

Conversation

@ebranlard
Copy link
Contributor

This pull request is ready to be merged

Feature or improvement description
Documentation added. A live version is available here:
https://ebranlard-openfast.readthedocs.io/en/f-extptfm-doc/source/user/extptfm/index.html

Related pull request
#344

Related issues
#852
#549
#485

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.28%. Comparing base (7a59bec) to head (af93cc4).
⚠️ Report is 4753 commits behind head on dev.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #858      +/-   ##
==========================================
+ Coverage   11.27%   11.28%   +0.01%     
==========================================
  Files         211      211              
  Lines      309733   310488     +755     
  Branches   180530   181011     +481     
==========================================
+ Hits        34910    35054     +144     
- Misses     230900   231363     +463     
- Partials    43923    44071     +148     
Flag Coverage Δ
regtests 11.18% <ø> (+0.01%) ⬆️
unittests 2.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebranlard -- Thank you for developing this documentation. Overall, an excellent documentation of the ExtPtfm module! Please find a few minor edits/corrections here. After these are addressed, please merge.

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my edits/comments!

@ebranlard ebranlard merged commit da7a714 into OpenFAST:dev Oct 15, 2021
@ebranlard ebranlard deleted the f/extptfm-doc branch November 12, 2021 19:23
@rafmudaf rafmudaf mentioned this pull request Mar 2, 2022
11 tasks
@Qiaoyanhui
Copy link

Dear jjonkman,
I am confused about how to obtain the mass, stiffness, damping, and excitation force matrices in the ExtPtfm module, especially how to consider coupled motions such as surge-pitch, pitch-yaw, and surge-yaw, and how to obtain non-diagonal elements in the mass, stiffness, damping, and excitation force matrices corresponding to coupled motions?
Best regards.

@jjonkman
Copy link
Collaborator

Dear @Qiaoyanhui,

It looks like you asked the same question in the following GitHub issue: #2275. I've now responded there and let's keep the conversation there.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants