Skip to content

Feature/interactive regression test plots#330

Merged
rafmudaf merged 13 commits intoOpenFAST:devfrom
RHammond2:feature/interactive_regression_test_plots
Dec 9, 2019
Merged

Feature/interactive regression test plots#330
rafmudaf merged 13 commits intoOpenFAST:devfrom
RHammond2:feature/interactive_regression_test_plots

Conversation

@RHammond2
Copy link
Contributor

THIS PULL REQUEST IS READY TO MERGE

Feature or improvement description

This pull requests modifies the regression testing suite to replace the visualizations with interactive visualizations, better accentuate which cases have failed in the export summary, and to clean up a few spots in the code to make it more pythonic. This work was done under the guidance of @rafmudaf.

Impacted areas of the software

This only impacts the regression testing suite.

@rafmudaf rafmudaf self-assigned this Sep 17, 2019
@rafmudaf
Copy link
Collaborator

@RHammond2 The Bokeh JavaScript files don't load for me. This is what I see in the JS console:

[Error] Failed to load resource: the server responded with a status of 403 () (bokeh.min.js.map, line 0)
[Error] Failed to load resource: the server responded with a status of 403 () (bokeh-widgets.min.js.map, line 0)

Any idea why?

@RHammond2
Copy link
Contributor Author

@rafmudaf I can't seem to find anything related to this issue. Are you blocking access within your browser; though, I'm not convinced that would give that error.

@rafmudaf
Copy link
Collaborator

I thought we discovered that the error above was only a problem when generating plots for cases that hadn't actually failed, but I ran this again after compiling in single precision so that most test cases fail and still same issue. So this is still pending.

On another note, since each plot is opened by clicking on a link (the id selector #), it can take a lot of clicks on the browser back button to get back to the main page. Adding a back to home button may be worthwhile.

@RHammond2
Copy link
Contributor Author

So this issue isn't actually blocking any of the functionality. There was a bit of confusion as to what was expected for output because we were looking at a case where none of the tests failed causing there to be no plots that are output. Even when plots are output the "error" comes up.

Where would the back to home button lead to for this if we are only looking at a single case? Would the idea be to access any of the cases as opposed to going through each directory separately?

Final updates include:
 - .../plots is removed entirely rather than its contents
 - -p and -v flags are fixed to act as expected
 - all channels are plot instead of only failing channels for a failing case
@RHammond2 RHammond2 force-pushed the feature/interactive_regression_test_plots branch from 628b89b to 038fc7f Compare December 9, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants