Fixed undefined behaviour in VariousWaves_Init.#191
Closed
friedrichatgc wants to merge 1 commit intoOpenFAST:devfrom
Closed
Fixed undefined behaviour in VariousWaves_Init.#191friedrichatgc wants to merge 1 commit intoOpenFAST:devfrom
friedrichatgc wants to merge 1 commit intoOpenFAST:devfrom
Conversation
InitOut%WaveDirArr(InitOut%NStepWave2) is not set in case of multi-directional waves. This leads to undefined behaviour (read of uninitialized value). Set this value to 0 as workaround (this generates defined behaviour). The correct fix is unclear: maybe InitOut%WaveDirArr(0) should be set to 0 and the index K starting from 1 then???
Contributor
|
I confirmed that is still the case with version 2.1. The issue is that the last value of The value should not be set to zero but set to a random value of I'll send another pull request to fix this. I've added an issue to reference this: #236 |
Contributor
|
I would cancel this pull request and merge #237 instead. |
Collaborator
|
@friedrichatgc thanks for your suggestion. Pull request #237 fixed this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InitOut%WaveDirArr(InitOut%NStepWave2) is not set in case of
multi-directional waves. This leads to undefined behaviour (read of
uninitialized value).
Set this value to 0 as workaround (this generates defined behaviour).
The correct fix is unclear: maybe InitOut%WaveDirArr(0) should be set
to 0 and the index K starting from 1 then???