SD: removing static improvement method (SIM) from SubDyn elastic output mesh (y3 mesh)#1526
Merged
ebranlard merged 9 commits intoOpenFAST:devfrom Apr 18, 2023
Merged
SD: removing static improvement method (SIM) from SubDyn elastic output mesh (y3 mesh)#1526ebranlard merged 9 commits intoOpenFAST:devfrom
ebranlard merged 9 commits intoOpenFAST:devfrom
Conversation
jjonkman
approved these changes
Apr 18, 2023
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
I have not reviewed the source code changes in great detail (I'm not an expert on the SubDyn source code anyway), but I agree with the need for this change to SubDyn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged
Feature or improvement description
This feature removes the static improvement method contribution from the Y3 mesh. The contribution is stilll present in the write outputs of SubDyn (displacements and elastic loads).
Additional cleanup of the code was performed as part of this pullrequest.
More variables are allocated as part of Misc to avoid reallocation at each time step. (e.g. AllOuts and internal load vector)
Impacted areas of the software
SubDyn
Additional supporting information
This change came about while thinking about the future tight coupling algorithm of OpenFAST and could improve the stability.
Test results, if applicable
Results should be unchanged.