hd: fix NBody>1 & NBodyMod=1 WAMIT2 bug#1480
Merged
andrew-platt merged 1 commit intoOpenFAST:devfrom Mar 7, 2023
Merged
Conversation
Some arrays in WAMIT2 were not initialized to the correct dimensions for multiple WAMIT bodies in the second order files.
Collaborator
Author
|
@luwang00, could you review this? |
jjonkman
approved these changes
Mar 7, 2023
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
I can't comment on the specific code changes, but they look correct at a high level. I'm glad to also hear that this change solves Alvaro's issue.
Contributor
|
@andrew-platt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is ready for merging.
Feature or improvement description
An outside user reported issues with a multibody potential flow HydroDyn model with a .12d input file. We traced this to some arrays in WAMIT2 were not initialized to the correct dimensions for multiple WAMIT bodies in the second order files.
Related issue, if one exists
None
Impacted areas of the software
HydroDyn 2nd order potential flow only (WAMIT2)
Additional supporting information
This bug was introduced in v2.5.0 when flexible multibody hydrodynamics was introduced.
Test results, if applicable
We have no publicly sharable models available that demonstrate this issue.