Merged
Conversation
…as) (#1428) * AD15: add back in the `Aero` names for output channels as alias Also switched back the internal variable tracking to `Aero` instead of `Fld` to make it a bit less confusing * Update input files 5MW_Land_ModeShapes * Update some regression tests (contained `Fld` names in input files and results)
* Disable doxygen on readthedocs as a temporary measure (does not really address #1423) * Fix local compiling of the docs when doxygen is enabled: **Description:** Something in RTD changed in January 2023 causing our documentation to fail if doxygen is enabled. This is due to an issue with the paths to doxygen. The change occurred sometime after the 3.4.0 release. * v3.4.0 (main, e8ec53f) docs build on Jan 11, https://readthedocs.org/projects/openfast/builds/19142412/ --> pass * v3.4.0 (main, e8ec53f) docs build on Jan 30, https://readthedocs.org/projects/openfast/builds/19322116/ --> fail Exactly what changed is a bit unknown: looking through the logs for both yielded very little useful information. A handful of python packages had minor updates, but nothing major that we would expect to change the results. Also whatever changed also affects local builds (only for updated python packages). For this fix, doxygen has been turned off on RTD (we don't think anyone uses it). Doxygen is still built locally and should work on most systems still.
andrew-platt
added
Module: AeroDyn
Type: Documentation
Feature: MHK
rafmudaf
approved these changes
Feb 10, 2023
deslaughter
approved these changes
Feb 10, 2023
jjonkman
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Pull request to merge
rc-3.4.1intomainand create a tagged release forv3.4.1.This release is a bugfix for 3.4.0
Test results, if applicable
See GitHub Actions
Release Checklist
Proposed Change Log
Documentation
#1442 `[BugFix] Doxygen builds failing on rtd, and locally. Documentation builds on readthedocs and local were failing due to a change in the backend of sphinx. This fixes local builds, but does not fix readthedocs builds. As a temporary workaround, doxygen is disabled on readthedocs.
AeroDyn15
#1428 AD15: revert to Aero names for output channels (Fld is now an alias). This fixes an issue introduced in v3.4.0 (#957)