Improve cmake's FindMKL to avoid runtime issues and preloading libraries#1427
Merged
andrew-platt merged 2 commits intoOpenFAST:devfrom Apr 10, 2023
Merged
Improve cmake's FindMKL to avoid runtime issues and preloading libraries#1427andrew-platt merged 2 commits intoOpenFAST:devfrom
andrew-platt merged 2 commits intoOpenFAST:devfrom
Conversation
andrew-platt
approved these changes
Apr 10, 2023
Collaborator
|
@andrew-platt do you know how this might affect CMake with Intel for Windows? In that case, is there a runtime library? |
Collaborator
|
@rafmudaf this worked ok with a CMake + OneAPI + VS just now. I started to wonder as well, so I tested it.
|
Collaborator
|
Thanks for checking @andrew-platt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This was a fix that we identified in WEIS projects running on Eagle a long time ago but of course forgot to submit a PR until we overwrote the fix with more recent OpenFAST versions.
When running on Eagle linux machines with the Intel compiler suite, we encounter an error that is well captured in various forums (here, here, here).
The suggested fix is to link to the
mkl_rtlibrary first or to preload the libraries in an environment variable using hard paths. The first approach is much more appealing and I can confirm that this has resolved our issues on Eagle using WEIS.Related issue, if one exists
Not that I know
Impacted areas of the software
Regression tests run with intel compilers
Additional supporting information
Let me know if I can augment the description.
Test results, if applicable
I think this will be easier to do using the Github Actions workflow via this PR.