OpenFAST build does not include src to build DISCON dynamic library

[HaymanConsulting]

A DISCON dynamic-linked library (DLL) is needed to run OpenFAST if the ServoDyn input file is using option 5 for the PCMode and VSContrl parameters.

The DISCON DLL is built from a fortran file containing the DISCON subroutine with the following interface:

SUBROUTINE DISCON ( avrSWAP, aviFAIL, accINFILE, avcOUTNAME, avcMSG ) BIND (C, NAME='DISCON')
!DEC$ ATTRIBUTES DLLEXPORT :: DISCON

We should probably include a 'dummy' DLL in a standard build via a DISCON.f90 file, and people can replace the dummy DISCON.f90 file with their own if they need a certain controller behavior. Perhaps this DISCON.f90 file lives in modules-local/servodyn/src ?

As a side note, various regression tests need different flavors of the DISCON DLL, what process is responsible for building these prior to launching regression tests? Perhaps this is a separate issue!

[sayerhs]

I thought we used the dynamic library loading capability to load the dll instead of compiling openfast with it, so why do we need a dummy DISCON.f90 file?

[HaymanConsulting]

You are correct, but how do I create the DISCON.DLL in the first place. The code and build of the dll from that code are not in OpenFAST. Where do we send people if they are to use that option. You have to have it available somewhere, right? From: Shreyas Ananthan [mailto:notifications@github.com] Sent: Tuesday, January 10, 2017 12:09 PM To: OpenFAST/OpenFAST Cc: Hayman, Gregory; Assign Subject: Re: [OpenFAST/OpenFAST] OpenFAST build does not include src to build DISCON dynamic library (#6) I thought we used the dynamic library loading capability to load the dll instead of compiling openfast with it, so why do we need a dummy DISCON.f90 file? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub<#6 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGcCp7rt-YjyOQf983PBGNdyfta3z144ks5rQ9degaJpZM4LfrR4>.

[gantech]

So, the DISCON.f90 file was in the CertTest directory in the earlier distributions of FAST. May be we include it in the test repo?

[sayerhs]

I see this as part of glue-codes similar to simulink or labview, provide an example of DISCON.f90 example that the user can modify and compile inside glue-codes. Most likely the DISCON interface would link to some matlab/simulink codebase (at least based on my experience at Envision).

[HaymanConsulting]

While that was true, it seems odd that something needed to use OpenFAST lives outside of the OpenFAST repo. I’m not sure I like OpenFAST-test as the home for Discon.f90 and it’s build system… From: Ganesh Vijayakumar [mailto:notifications@github.com] Sent: Tuesday, January 10, 2017 12:36 PM To: OpenFAST/OpenFAST Cc: Hayman, Gregory; Assign Subject: Re: [OpenFAST/OpenFAST] OpenFAST build does not include src to build DISCON dynamic library (#6) So, the DISCON.f90 file was in the CertTest directory in the earlier distributions of FAST. May be we include it in the test repo? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub<#6 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGcCp7V5tgGZS5DF5Q_qM8W0A112ex4wks5rQ92ygaJpZM4LfrR4>.

[rafmudaf]

This issue has been fixed by pull request #115