-
-
Notifications
You must be signed in to change notification settings - Fork 513
Fix text-muted visibility in dark mode on welcome page #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
|
🌐 GitHub Pages Preview Ready! Your static preview is now available at: 📄 What's included:
For full functionality testing: Use the Docker preview instead. 🔄 Auto-updates: This preview will be updated automatically when you push new commits to this PR. Static preview with Thymeleaf generation by GitHub Actions |
|
🔨 Preview Build Complete! Your changes have been built and pushed to GitHub Container Registry. 🐳 Docker Image: 📦 Download & Test Locally:
# Download the artifact, extract it, then:
docker load < wrongsecrets-preview.tar
docker run -p 8080:8080 wrongsecrets-preview🚀 Alternative - Pull from Registry: docker pull ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2231-7768514
docker run -p 8080:8080 ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2231-7768514Then visit: http://localhost:8080 📝 Changes in this PR: Visual diff screenshots will be available shortly... Preview built by GitHub Actions |
|
🔨 Preview Build Complete! Your changes have been built and pushed to GitHub Container Registry. 🐳 Docker Image: 📦 Download & Test Locally:
# Download the artifact, extract it, then:
docker load < wrongsecrets-preview.tar
docker run -p 8080:8080 wrongsecrets-preview🚀 Alternative - Pull from Registry: docker pull ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2231-7768514
docker run -p 8080:8080 ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2231-7768514Then visit: http://localhost:8080 📝 Changes in this PR: Visual diff screenshots will be available shortly... Preview built by GitHub Actions |
|
📸 Visual Diff Available! Screenshots have been generated comparing your changes with the main branch. Download Visual Diff Artifacts The artifacts contain:
Compare these images to see the visual impact of your changes! Visual diff generated by GitHub Actions |
|
📸 Visual Diff Available! Screenshots have been generated comparing your changes with the main branch. Download Visual Diff Artifacts The artifacts contain:
Compare these images to see the visual impact of your changes! Visual diff generated by GitHub Actions |
|
📸 Visual Diff Ready! Screenshots comparing your changes with the main branch are available: 📁 Download Visual Diff Artifacts 🖼️ Included screenshots:
🔍 How to review:
💡 Tip: Use an image comparison tool or open both images in separate browser tabs to spot differences easily. Visual diff generated by GitHub Actions • PR #2231 |
|
📸 Visual Diff Ready! Screenshots comparing your changes with the main branch are available: 📁 Download Visual Diff Artifacts 🖼️ Included screenshots:
🔍 How to review:
💡 Tip: Use an image comparison tool or open both images in separate browser tabs to spot differences easily. Visual diff generated by GitHub Actions • PR #2231 |
|
🧹 Preview Cleanup Complete The static preview for this PR has been removed from GitHub Pages. Thanks for contributing to WrongSecrets! 🎉 Cleanup completed by GitHub Actions |
The difficulty and environment explanation text was not visible in dark mode on the main welcome screen. The text "Difficulty: ⭐ (Easy) ⭐⭐ (Medium) ⭐⭐⭐ (Hard) ⭐⭐⭐⭐ (Expert) ⭐⭐⭐⭐⭐ (Master) | Environment: Where the challenge can be solved" used Bootstrap's
text-mutedclass which has poor contrast against the dark background.Root Cause
The
text-mutedclass in Bootstrap applies a gray color (#6c757d) that becomes virtually invisible when the page is in dark mode with a dark background.Solution
Added a CSS rule
.dark-mode .text-muted { color: var(--bs-gray-300) !important; }to ensure proper contrast in dark mode. The fix uses the existing CSS variable--bs-gray-300which provides good readability against the dark background while maintaining consistency with the existing dark mode color scheme.Before and After
Before Fix (Dark Mode):

After Fix (Dark Mode):

Files Changed
src/main/resources/static/css/dark.css- Added dark mode styling for text-mutedstatic-site/pr-2125/pages/welcome.html- Applied same fix to static site previewThe fix is minimal, targeted, and maintains backward compatibility while significantly improving readability in dark mode.
Fixes #2230.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.