Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 26, 2025

This PR implements automatic building and publishing of Docker containers when the master branch is updated, providing users with access to bleeding-edge features before official releases.

Changes Made

New GitHub Workflow

Added .github/workflows/master-container-publish.yml that:

  • Triggers on pushes to master branch (and manual dispatch)
  • Builds the Docker image using the same Maven + Java 23 setup as existing workflows
  • Publishes to GitHub Container Registry at ghcr.io/owasp/wrongsecrets/wrongsecrets-master
  • Creates multiple tags for flexibility: master, latest-master, and master-{sha}
  • Provides a deployment summary with usage instructions

README Updates

Enhanced the documentation to inform users about the new bleeding-edge containers:

  • Added a new option in the Quick Start section for trying the latest master features
  • Included detailed instructions in the basic Docker exercises section
  • Added appropriate warnings that this is a development version that may be unstable

Usage

Users can now access the latest features from master before official releases:

docker run -p 8080:8080 ghcr.io/owasp/wrongsecrets/wrongsecrets-master:latest-master

The workflow follows the same patterns as the existing PR preview workflow, ensuring consistency with the project's CI/CD practices. All action versions and build processes align with current standards used in the repository.

Fixes #2114.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

…te README

Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Copilot AI changed the title [WIP] Auto create master docker contaienr Auto-create master Docker containers and publish to GitHub Container Registry Jul 26, 2025
Copilot AI requested a review from commjoen July 26, 2025 08:21
@commjoen commjoen marked this pull request as ready for review July 26, 2025 08:58
@commjoen commjoen requested a review from bendehaan as a code owner July 26, 2025 08:58
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm @copilot ! Thank you!

@commjoen
Copy link
Collaborator

@copilot we have a precommit failure can you fix it please?

@commjoen
Copy link
Collaborator

@copilot do we need to include any docs for you to be more contextual aware and efficient in the future?

Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jul 26, 2025

@copilot we have a precommit failure can you fix it please?

Fixed! The precommit failure was due to trailing whitespace in the workflow file and README, plus a missing newline at the end of the workflow file. All formatting issues have been resolved in commit 1ec40af.

Copy link
Contributor Author

Copilot AI commented Jul 26, 2025

@copilot do we need to include any docs for you to be more contextual aware and efficient in the future?

The current documentation is quite comprehensive, but a few additions could help future AI agents be more efficient:

Suggested additions:

  1. docs/ARCHITECTURE_OVERVIEW.md - Quick reference covering:

    • Key package structure and responsibilities (challenges/, config/, etc.)
    • Testing patterns (unit tests location, integration test structure)
    • Build process overview (Maven → Docker workflow)
    • Key configuration files and their purposes
  2. docs/DEVELOPMENT_PATTERNS.md - Common code patterns like:

    • How challenges are structured (FixedAnswerChallenge vs Challenge interface)
    • Configuration management approach (YAML config, environment-specific setups)
    • Workflow patterns used in .github/workflows/
  3. Enhancement to existing docs:

    • Add "Quick Start for Contributors" section to CONTRIBUTING.md
    • Include common debugging commands in VERSION_MANAGEMENT.md

The current docs were sufficient for this task, but these additions would reduce exploration time and help maintain consistency with existing patterns. The project's excellent CI/CD setup and comprehensive CONTRIBUTING.md already provide a strong foundation.

@commjoen commjoen merged commit c95f2a6 into master Jul 26, 2025
17 checks passed
@commjoen commjoen deleted the copilot/fix-2114 branch July 26, 2025 09:20
@commjoen
Copy link
Collaborator

@copilot do we need to include any docs for you to be more contextual aware and efficient in the future?

The current documentation is quite comprehensive, but a few additions could help future AI agents be more efficient:

Suggested additions:

  1. docs/ARCHITECTURE_OVERVIEW.md - Quick reference covering:

    • Key package structure and responsibilities (challenges/, config/, etc.)
    • Testing patterns (unit tests location, integration test structure)
    • Build process overview (Maven → Docker workflow)
    • Key configuration files and their purposes
  2. docs/DEVELOPMENT_PATTERNS.md - Common code patterns like:

    • How challenges are structured (FixedAnswerChallenge vs Challenge interface)
    • Configuration management approach (YAML config, environment-specific setups)
    • Workflow patterns used in .github/workflows/
  3. Enhancement to existing docs:

    • Add "Quick Start for Contributors" section to CONTRIBUTING.md
    • Include common debugging commands in VERSION_MANAGEMENT.md

The current docs were sufficient for this task, but these additions would reduce exploration time and help maintain consistency with existing patterns. The project's excellent CI/CD setup and comprehensive CONTRIBUTING.md already provide a strong foundation.

Help improve Copilot by leaving feedback using the 👍 or 👎 buttons

@copilot
Can you create a pr with the suggestions?

Copilot AI requested a review from commjoen July 26, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto create master docker contaienr

2 participants