Skip to content

Conversation

@za
Copy link
Contributor

@za za commented Apr 14, 2025

Closes Issue: #1975

@za za requested review from bendehaan and commjoen as code owners April 14, 2025 08:01
@za
Copy link
Contributor Author

za commented Apr 14, 2025

Now, the AWS terratests ran without any problem @commjoen 🥳

➜  aws git:(issue-1975-k8s-1.32) ✗ go test -timeout 999999s 

TestTerraformWrongSecretsAWS 2025-04-14T16:43:58+07:00 logger.go:67: Destroy complete! Resources: 83 destroyed.
TestTerraformWrongSecretsAWS 2025-04-14T16:43:58+07:00 logger.go:67: 
PASS
ok      wrongsecrets    1631.546s

@commjoen
Copy link
Collaborator

Awesome! Can you run the GCP and Azure tests as well please?

@za
Copy link
Contributor Author

za commented Apr 15, 2025

OK, on it now @commjoen

GCP test result:

➜  gcp git:(issue-1975-k8s-1.32) ✗ go test -timeout 999999s 

TestTerraformWrongSecretsGCP 2025-04-15T15:20:12+07:00 logger.go:67: Destroy complete! Resources: 21 destroyed.
TestTerraformWrongSecretsGCP 2025-04-15T15:20:12+07:00 logger.go:67: 
PASS
ok      wrongsecrets    1015.395s

@za
Copy link
Contributor Author

za commented Apr 15, 2025

Azure test result:

➜  azure git:(issue-1975-k8s-1.32) ✗ go test -timeout 999999s    

TestTerraformWrongSecretsAzure 2025-04-15T16:23:33+07:00 logger.go:67: Destroy complete! Resources: 17 destroyed.
TestTerraformWrongSecretsAzure 2025-04-15T16:23:33+07:00 logger.go:67: 
PASS
ok      wrongsecrets    1024.904s

All good then @commjoen Should we proceed to merge the PR now?

@commjoen
Copy link
Collaborator

yes sir!

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the upgrade work!

@commjoen commjoen merged commit 6727f41 into OWASP:master Apr 15, 2025
17 checks passed
@za
Copy link
Contributor Author

za commented Apr 15, 2025

Thanks for the review @commjoen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants