Skip to content

Conversation

@commjoen
Copy link
Collaborator

@commjoen commjoen commented Mar 6, 2025

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

There were bugs in the Azure setup as the new TF provider no longer allowed for the old setup. Secondly the k8s template was wrong. Now both have been fixed in this PR.

Note: we do see that the current resource defs on TF are very tight for this setup. it works, but you cannot deploy anything next to the testing setup.

Relations

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen requested a review from bendehaan as a code owner March 6, 2025 16:22
@commjoen
Copy link
Collaborator Author

commjoen commented Mar 6, 2025

issue that still needs fixing with the container:

kubectl logs -f secret-challenge-5997548cf7-c4jnt 
/bin/sh: source: line 0: can't open '/vault/secrets/challenge46': No such file or directory

@commjoen commjoen changed the title first fixes for azure First fixes for Azurerm TF provider config Mar 6, 2025
@commjoen commjoen changed the title First fixes for Azurerm TF provider config Fixes for Azure deployment: update readme, TF process, and K8s templates Mar 7, 2025
@commjoen commjoen merged commit 19a9c53 into master Mar 7, 2025
17 checks passed
@commjoen commjoen deleted the auzre-update branch March 7, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants