Skip to content

Conversation

@za
Copy link
Contributor

@za za commented Feb 25, 2025

Reason: some of the CSP is ending support for k8s 1.30

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Update k8s version to 1.31

Relations

#1848

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

OWASP#1848
Reason: some of the CSP is ending support for k8s 1.30
@za
Copy link
Contributor Author

za commented Feb 25, 2025

Hi @commjoen kindly check the PR.

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @za ! Thank you for the PR! Did you test this on the cloud providers?

@za
Copy link
Contributor Author

za commented Feb 25, 2025

Hi @za ! Thank you for the PR! Did you test this on the cloud providers?

No, I haven't tested it @commjoen

@commjoen
Copy link
Collaborator

Hi @za ! Thank you for the PR! Did you test this on the cloud providers?

No, I haven't tested it @commjoen

I guess they first need to be tested before we can continue .

@za
Copy link
Contributor Author

za commented Feb 25, 2025

I guess they first need to be tested before we can continue .

I'll find a time to test @commjoen

In the mean time, I can see that all 16 github actions tests are passed ✅

@za
Copy link
Contributor Author

za commented Mar 4, 2025

Running terratest on AWS:

➜  aws git:(issue-1848-update-k8s-1.31) ✗ go test -timeout 99999s  

TestTerraformWrongSecretsAWS 2025-03-04T15:15:57+07:00 logger.go:66: module.vpc.aws_vpc.this[0]: Destruction complete after -5s
TestTerraformWrongSecretsAWS 2025-03-04T15:15:57+07:00 logger.go:66:
TestTerraformWrongSecretsAWS 2025-03-04T15:15:57+07:00 logger.go:66: Destroy complete! Resources: 82 destroyed.
TestTerraformWrongSecretsAWS 2025-03-04T15:15:57+07:00 logger.go:66:
--- FAIL: TestTerraformWrongSecretsAWS (1751.62s)
    apply.go:15:
                Error Trace:    /home/za/go/pkg/mod/github.com/gruntwork-io/terratest@v0.47.2/modules/terraform/apply.go:15
                                                        /home/za/git/wrongsecrets/aws/wrongsecrets_aws_test.go:48
                Error:          Received unexpected error:
                                FatalError{Underlying: error while running command: exit status 1; ╷
                                │ Error: creating SSM Parameter (wrongsecretvalue): operation error SSM: PutParameter, https response error StatusCode: 400, RequestID: 3e063e0d-ade8-494f-b54b-ea42d89982b5, ParameterAlreadyExists: The parameter already exists. To overwrite this value, set the overwrite option in the request to true.
                                │
                                │   with aws_ssm_parameter.secret,
                                │   on secrets.tf line 87, in resource "aws_ssm_parameter" "secret":
                                │   87: resource "aws_ssm_parameter" "secret" {
                                │
                                ╵}
                Test:           TestTerraformWrongSecretsAWS
FAIL
exit status 1
FAIL    wrongsecrets    1751.823s

Hi @commjoen any hint why the test is failed?

@commjoen
Copy link
Collaborator

commjoen commented Mar 4, 2025

Running terratest on AWS:

➜  aws git:(issue-1848-update-k8s-1.31) ✗ go test -timeout 99999s  

TestTerraformWrongSecretsAWS 2025-03-04T15:15:57+07:00 logger.go:66: module.vpc.aws_vpc.this[0]: Destruction complete after -5s
TestTerraformWrongSecretsAWS 2025-03-04T15:15:57+07:00 logger.go:66:
TestTerraformWrongSecretsAWS 2025-03-04T15:15:57+07:00 logger.go:66: Destroy complete! Resources: 82 destroyed.
TestTerraformWrongSecretsAWS 2025-03-04T15:15:57+07:00 logger.go:66:
--- FAIL: TestTerraformWrongSecretsAWS (1751.62s)
    apply.go:15:
                Error Trace:    /home/za/go/pkg/mod/github.com/gruntwork-io/terratest@v0.47.2/modules/terraform/apply.go:15
                                                        /home/za/git/wrongsecrets/aws/wrongsecrets_aws_test.go:48
                Error:          Received unexpected error:
                                FatalError{Underlying: error while running command: exit status 1; ╷
                                │ Error: creating SSM Parameter (wrongsecretvalue): operation error SSM: PutParameter, https response error StatusCode: 400, RequestID: 3e063e0d-ade8-494f-b54b-ea42d89982b5, ParameterAlreadyExists: The parameter already exists. To overwrite this value, set the overwrite option in the request to true.
                                │
                                │   with aws_ssm_parameter.secret,
                                │   on secrets.tf line 87, in resource "aws_ssm_parameter" "secret":
                                │   87: resource "aws_ssm_parameter" "secret" {
                                │
                                ╵}
                Test:           TestTerraformWrongSecretsAWS
FAIL
exit status 1
FAIL    wrongsecrets    1751.823s

Hi @commjoen any hint why the test is failed?

It looks like deletion protection ins in place? we need to randomize this possibly. did you do a test twice while the deletion was not yet completed maybe?

@za
Copy link
Contributor Author

za commented Mar 4, 2025

@commjoen No, I only run it once.

@commjoen
Copy link
Collaborator

commjoen commented Mar 4, 2025

@commjoen No, I only run it once.

Can we check on this with Slack?

@commjoen
Copy link
Collaborator

commjoen commented Mar 11, 2025

Success:

  • minikube
  • aws
  • azure

failure in terratest:

  • gcp

@commjoen
Copy link
Collaborator

GCP is fixed in #1903, we can merge this ;) .

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @za !

@commjoen commjoen merged commit 30eaf5b into OWASP:master Mar 12, 2025
17 checks passed
@za
Copy link
Contributor Author

za commented Mar 12, 2025

AWS terratest result:

➜  aws git:(issue-1848-update-k8s-1.31) ✗ go test -timeout 99999s 
...
TestTerraformWrongSecretsAWS 2025-03-12T14:41:09+07:00 logger.go:66: Destroy complete! Resources: 83 destroyed.
TestTerraformWrongSecretsAWS 2025-03-12T14:41:09+07:00 logger.go:66: 
PASS
ok      wrongsecrets    1817.440s

We're good on AWS @commjoen

@za za deleted the issue-1848-update-k8s-1.31 branch March 12, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants