Open
Conversation
echoix
requested changes
Mar 1, 2026
Member
echoix
left a comment
There was a problem hiding this comment.
Can you review the diff, and only changes the lines needed? You removed lots of comments, changed comments where not needed, in short, it’s hiding the real useful changes.
Add yourself in the loop, like we wrote in the contribution guidelines/ai policy, and come ping me back when it will be worth it :)
Your solution with the run_id is probably better than using the ref/base_ref (that was previously mentionnend), as it it less prone to injection, so a bit better on security.
Member
There was a problem hiding this comment.
Revert that file, it’s not really part of the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issuue #7115 ... related to the
update-i18njob in thePeriodic updateworkflow.Previously, the workflow used a static branch name:
This meant that every time the workflow ran, it reused the same branch to create or update a Pull Request. As a result, only one translation update PR could exist at a time. If the workflow was triggered again (either by schedule or manually) while a previous PR was still open, the same branch would be reused and the existing PR would be updated or overwritten.
What was changed
The branch name used by the
create-pull-requestaction has been updated to include a unique identifier:so this ensures that
Verification
The workflow was manually triggered manually on a fork repo, and the branches were different each time. Each run created a distinct branch and corresponding Pull Request, confirming that branch names no longer collide.