g.parser: Missing support G_OPT_F_FORMAT in python %option#7071
g.parser: Missing support G_OPT_F_FORMAT in python %option#7071petrasovaa merged 8 commits intoOSGeo:mainfrom
Conversation
|
I'm not sure which type of tests should I add so that missing to add may be avoided in future? |
ninsbl
left a comment
There was a problem hiding this comment.
Looks in principle good to me. Just one minur comment...
The failing tests are likely unrelated...
|
There is likely a Python tool which should probably have it since the time this was introduced. Is there? |
Does not seem so. See: https://github.com/search?q=repo%3AOSGeo%2Fgrass%20path%3A*.py%20language%3APython%20G_OPT_F_FORMAT&type=code |
|
db.univar, v.db.univar, and t.rast.list could have used it: https://github.com/search?q=repo%3AOSGeo%2Fgrass%20path%3A*.py%20language%3APython%20%22key:%20format%22&type=code |
|
...should have it already, but it does not is what I meant to say. |
wenzeslaus
left a comment
There was a problem hiding this comment.
I think we should have it in these tools and this PR is the place to do it.
|
Thank you! |
petrasovaa
left a comment
There was a problem hiding this comment.
Looks good to go! Thanks!
Currently using below gives the unexpected warning:
This was detected as a part of #7051 (comment).
The reason was
G_OPT_F_FORMATis missing in standard_option.c.NOTE: The C code is not affected because, those directly use
G_define_standard_option(), but for parsing python%option, we usedefine_standard_optionwhich compares the string defined in theSTD_OPT_STRINGS(with same index as enum declared in gis.h).