cohort_instantiation_date or cohort_initiation_date?

[schuemie]

In the documentation there is a field in the cohort_definition table called cohort_instantiation_date: https://github.com/OHDSI/CommonDataModel/blob/master/Documentation/CommonDataModel_Wiki_Files/StandardizedVocabularies/COHORT_DEFINITION.md

In the ddl this field is called cohort_initiation_date: https://github.com/OHDSI/CommonDataModel/blob/master/Sql%20Server/OMOP%20CDM%20ddl%20-%20SQL%20Server.sql#L175

I don't think anyone has used this field ever. I suggest sticking to cohort_initiation_date and changing the documentation so we don't have to update all our databases and software.

[cgreich]

@schuemie:

We are fixing hte way the DDL is made (using SQLRender), so these silly typos stop. And we need to discuss the cohort table and schema situation.

[schuemie]

@cgreich :

Could you elaborate a bit more on the process you are developing? I want to automatically generate Rabbit-in-a-Hat CSV specification files whenever the CDM is updated, so maybe I can latch on to the new process?

[clairblacketer]

@schuemie I am writing a package that will write the DDLs from one OHDSql script as well as create the pdf for the new CDM version from the wiki .md files. I would be happy to work with you on it!

[cgreich]

@schuemie:

Not sure. We want to auto-create DDL from one master DDL. Are DDLs what you need?

[schuemie]

I just need a list of tables, fields per tables, and some info per field (type, nullable, short description as found in the CDM documentation).

[cgreich]

I see. That should be easily rippable from the documentation (the tables have a very distinct syntax), but somebody would have to write a crawler.

Or you use the DDL. However, they don't contain the short field descriptions. @dtorok added that some time in an earlier version, but today it's not in there. We could do that, though.

[clairblacketer]

PR #114 adds comments into the Postgres version though I am not sure the best way to integrate them with the sqlrender version I am creating.

[vojtechhuser]

+1 for taking one flavor and generating the others.