Migrate build pipeline to 1ES #42
Conversation
gathogojr
force-pushed
the
maintenance/onboard-1es-pipeline
branch
8 times, most recently
from
c54145a to
0747bde
Compare
gathogojr
force-pushed
the
maintenance/onboard-1es-pipeline
branch
from
0747bde to
fec0c30
Compare
| displayName: Use .NET 3.x | ||
| inputs: | ||
| packageType: 'sdk' |
There was a problem hiding this comment.
Which framework does modelbuilder target? shouldn't it target .net 8.0? If so,,,, the test projects too should be updated and this should be updated to .net 8.0
There was a problem hiding this comment.
| versionSpec: '>=5.2.0' | ||
|
|
||
| - task: UseDotNet@2 | ||
| displayName: Use .NET 6.0 |
There was a problem hiding this comment.
should this be .net 8.0?
There was a problem hiding this comment.
@ElizabethOkerio I'll update that after I merge #41. This pull request is targeting current main that was targeting .NET 6.0
| checkLatest: true | ||
|
|
||
| - task: UseDotNet@2 | ||
| displayName: Use .NET 6.0 |
There was a problem hiding this comment.
same here? net.8.0?
| displayName: Use .NET 3.x | ||
| inputs: | ||
| packageType: 'sdk' | ||
| version: '3.x' |
| name: 1ESPipelineTemplates/1ESPipelineTemplates | ||
| ref: refs/tags/release | ||
|
|
||
| variables: |
There was a problem hiding this comment.
I think you're missing some variables from the other pipelines...I'm not sure whether it matters though :
variables:
- name: NugetSecurityAnalysisWarningLevel
value: none - name: runCodesignValidationInjection
value: false
There was a problem hiding this comment.
I thought of adding them but I wasn't sure whether they're strictly necessary especially because they appear to be assigned default values. I'll evaluate whether they're necessary when updating the template to use .NET 8.0
There was a problem hiding this comment.
Actually, those variables are not applied anywhere even in the other pipelines.
3 participants
Migrate build pipeline to 1ES