Skip to content

Conversation

@samtrion
Copy link
Contributor

@samtrion samtrion commented Jan 7, 2022

Issues

None

Description

With this PR, the use of #if NET6_0 preprocessor instructions has been updated to remain compatible for future versions. As described in the article OR_GREATER preprocessor symbols for TFMs, no additional customizations will be necessary with future .NET versions.

  • .NET 5 and later
    • Applies to netX.Y and the NET symbol
    • For example, net6.0 will define NET, NET6_0, NET6_0_OR_GREATER and NET5_0_OR_GREATER.
    • This will also include the corresponding defines a .NET Core 3.1 successor would have gotten. For example, net5.0 will also define NETCOREAPP, NETCOREAPP3_1_OR_GREATER..NETCOREAPP1_0_OR_GREATER.
    • This will neither define a NETCOREAPP5_0 nor NETCOREAPP5_0_OR_GREATER.

Checklist (Uncheck if it is not completed)

  • Test cases added Not necessary, as only housekeeping changes
  • Build and test with one-click build and test script passed

Additional work necessary

None

@pull-request-quantifier-deprecated

This PR has 28 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +14 -14
Percentile : 11.2%

Total files changed: 9

Change summary by file extension:
.cs : +14 -14

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost
Copy link

ghost commented Jan 7, 2022

CLA assistant check
All CLA requirements met.

@samtrion
Copy link
Contributor Author

samtrion commented Mar 2, 2022

@xuzhg, are there any concerns from your side as to why the PR is not merged?

@xuzhg xuzhg merged commit c5cd1ed into OData:main Mar 2, 2022
@xuzhg
Copy link
Member

xuzhg commented Mar 2, 2022

@xuzhg, are there any concerns from your side as to why the PR is not merged?

Yes, thanks, I merged that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants