Add Migrating to a New Digest Algorithm #432
Conversation
zimeon
requested review from
ahankinson,
awoods,
julianmorley,
neilsjefferies and
rosy1280
rosy1280
left a comment
rosy1280
left a comment
There was a problem hiding this comment.
minor editorial changes requested
neilsjefferies
left a comment
neilsjefferies
left a comment
There was a problem hiding this comment.
It would be better for the example if the SHA512 digests were more clearly distinct from the SHA256's to make it clear what has changed where in the inventory. And/or highlight them.
|
@neilsjefferies you have spotted a real error in that my example the truncated sha256 were actually just differently truncated sha512... I'll fix that. Perhaps also it would help to make the truncated sha512 obviously twice as long as the truncated sha256 |
|
I have not yet given this a full review... but there seems to be a lot of whitespace/reformatting updates that are otherwise unrelated to this PR. Can those be removed? |
|
@awoods - not without a bunch of work |
|
As the changes are non-content, I'd be OK with just leaving them; they're easy to ignore. |
Co-authored-by: Andrew Woods <awoods@duraspace.org>
zimeon
dismissed stale reviews from rosy1280, neilsjefferies, and ahankinson
via
192247c
|
I merged in @awoods removal of formatting fixes (I guess we should have a separate PR for those too). Needs re-review |
+1 to having a separate, non-functional, whitespace-cleanup PR. |
julianmorley
left a comment
julianmorley
left a comment
There was a problem hiding this comment.
Assuming I'm reading the spec right, although address 'should' be in URI format, may as well go for gold and set a good example.
Fixes #430