-
Notifications
You must be signed in to change notification settings - Fork 327
Upgrade to Spring Boot 4 #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Upgrade to Spring Boot 4 #2219
+6,002
−2,549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbakker
reviewed
Oct 1, 2025
graphql-dgs-client/src/main/kotlin/com/netflix/graphql/dgs/client/GraphQLResponse.kt
Outdated
Show resolved
Hide resolved
…use of a null issue with kotlin
Update package names of excluded autoconfigs for SB4
Spring Boot 4 RC2 upgrade
paulbakker
reviewed
Dec 3, 2025
graphql-dgs-client/src/test/java/com/netflix/graphql/client/GraphQLResponseJavaTest.java
Outdated
Show resolved
Hide resolved
paulbakker
reviewed
Dec 3, 2025
graphql-dgs-client/src/test/kotlin/com/netflix/graphql/dgs/client/scalar/DateRangeScalar.kt
Show resolved
Hide resolved
sjohnr
reviewed
Dec 3, 2025
Contributor
sjohnr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of comments below, just to note some things I spotted.
...dgs-client/src/test/kotlin/com/netflix/graphql/dgs/client/CustomReactiveGraphQLClientTest.kt
Outdated
Show resolved
Hide resolved
graphql-dgs-client/src/test/kotlin/com/netflix/graphql/dgs/client/scalar/DateRangeScalar.kt
Show resolved
Hide resolved
graphql-dgs-client/src/test/kotlin/com/netflix/graphql/dgs/client/scalar/DateRangeScalar.kt
Outdated
Show resolved
Hide resolved
graphql-dgs-client/src/test/kotlin/com/netflix/graphql/dgs/client/scalar/DateRangeScalar.kt
Show resolved
Hide resolved
...ing-graphql/src/main/kotlin/com/netflix/graphql/dgs/springgraphql/DgsGraphQLSourceBuilder.kt
Outdated
Show resolved
Hide resolved
sjohnr
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
first
Pull Request type
Changes in this PR
This PR upgrades dgs-framework to spring framework 7 and spring-graphql 4
Issue #2218
This is a breaking major version change due to fundamental API changes in upstream OSS spring.