Add ctl_printf and allow it to use a callback if set#39
Merged
stevengj merged 1 commit intoNanoComp:masterfrom Apr 5, 2019
ChristopherHogan:chogan/ctl_printf
Merged
Add ctl_printf and allow it to use a callback if set#39stevengj merged 1 commit intoNanoComp:masterfrom ChristopherHogan:chogan/ctl_printf
stevengj merged 1 commit intoNanoComp:masterfrom
ChristopherHogan:chogan/ctl_printf
Conversation
stevengj
reviewed
Apr 5, 2019
| /**************************************************************************/ | ||
|
|
||
| /* Allows writing to Python's stdout when running from Meep's Python interface */ | ||
| void (*ctl_printf_callback)(const char *s) = NULL; |
Collaborator
There was a problem hiding this comment.
Shouldn’t this be declared in the header?
Contributor
Author
There was a problem hiding this comment.
I was going to declare it in meep.i, but yeah, I guess it belongs in ctlgeom.h. Fixed in #40.
bmwiedemann
added a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Aug 17, 2020
https://build.opensuse.org/request/show/827344 by user badshah400 + dimstar_suse - Update Source URL, moved to https://github.com/NanoComp/libctl. - update to 4.5.0: * New `make_slanted_prism` functions to make a prism with a given sidewall angle (gh#NanoComp/libctl#53). * Defined `LIBCTL_MAJOR_VERSION` etc. in `ctlgeom.h` header file when using stand-alone libctlgeom. * Bugfix in point-in-prism test (gh#NanoComp/libctl#49). * `geom_object_volume` function to get the volume of a 3d object (accelerates `box_overlap_with_object` for objects completely within a box) (gh#NanoComp/libctl#45). * `ctl_printf_callback` so that callers can capture stdout (gh#NanoComp/libctl#39).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stevengj @oskooi