fix(utils): extract provider error fields from response data directly#5634
Open
hassan254-prog wants to merge 1 commit intomasterfrom
Open
fix(utils): extract provider error fields from response data directly#5634hassan254-prog wants to merge 1 commit intomasterfrom
hassan254-prog wants to merge 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
No issues found; changes appear correct and tests cover expected behavior.
Status: No Issues Found | Risk: Low
Review Details
📁 2 files reviewed | 💬 0 comments
Instruction Files
├── .claude/
│ ├── agents/
│ │ └── nango-docs-migrator.md
│ └── skills/
│ ├── agent-builder-skill/
│ │ ├── EXAMPLES.md
│ │ └── SKILL.md
│ ├── creating-integration-docs/
│ │ └── SKILL.md
│ └── creating-skills-skill/
│ └── SKILL.md
├── AGENTS.md
└── GEMINI.md
TBonnin
reviewed
Mar 16, 2026
| if (!(field in responseData)) { | ||
| continue; | ||
| } | ||
| const value = (responseData as Record<string, unknown>)[field]; |
Collaborator
There was a problem hiding this comment.
we are changing the semantic of the logic, not looking at responseData.error anymore but responseData. Anything in .error will be skipped since in the line below object value are filtered out.
Are we not breaking current behavior?
| continue; | ||
| } | ||
| const value = (responseData as Record<string, unknown>)[field]; | ||
| if (typeof value !== 'object' || value === null) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the problem and your solution
Adjust provider error extraction from
response.datainstringifyErrorUpdates
stringifyErrorto extract whitelisted provider error fields directly fromresponse.datarather than only from a nestedresponse.data.errorobject, skipping object values to avoid nested payloads. Tests inpackages/utils/lib/errors.unit.test.tsare revised and expanded to cover top-level field extraction, invalid structures, and priority over Boom payloads.This summary was automatically generated by @propel-code-bot