Add phase 1 of CUDA Graphs support #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vzhurba01
force-pushed
the
114-graphs-initial
branch
from
7fe7e7d to
d82f799
Compare
Member
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Open
1 task
vzhurba01
force-pushed
the
114-graphs-initial
branch
2 times, most recently
from
a565301 to
ce5bf62
Compare
vzhurba01
force-pushed
the
114-graphs-initial
branch
from
ce5bf62 to
5e7713a
Compare
vzhurba01
changed the title
Contributor
Author
|
/ok to test 5e7713a |
Contributor
Author
|
/ok to test bad5c3e |
vzhurba01
force-pushed
the
114-graphs-initial
branch
from
29f8ed8 to
4803dac
Compare
Contributor
Author
|
/ok to test 4803dac |
Contributor
Author
|
/ok to test f635a20 |
Contributor
Author
|
/ok to test fa96f48 |
Contributor
Author
|
/ok to test 9bb2b9b |
Contributor
Author
|
/ok to test b577351 |
Contributor
Author
|
/ok to test 090edcc |
Contributor
Author
|
/ok to test 6d037dc |
vzhurba01
force-pushed
the
114-graphs-initial
branch
from
6d037dc to
1c41c2a
Compare
Contributor
Author
|
/ok to test 1c41c2a |
Contributor
Author
|
/ok to test 27f674c |
Member
|
/ok to test de22d5f |
leofang
reviewed
Jun 9, 2025
Member
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
LGTM overall, thanks a lot @vzhurba01 for solid works in design/implementation/testing! I left a few hopefully quick questions mainly on naming of a few things.
Member
|
/ok to test ded7844 |
leofang
previously approved these changes
Jun 10, 2025
Member
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
LGTM! As discussed offline @vzhurba01 plz take another look (at my changes) when you get a chance.
vzhurba01
commented
Jun 10, 2025
Member
|
Thanks, Vlad! Since the CI was green and the last change is string-only, let me admin-merge it. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #114