-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fuse MLA DOWN projection GEMMs #3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
is there a PR to dev that we can link? i don't see the same changes on dev branch currently? |
| if multi_latent_attention: | ||
| assert qk_l2_norm is False, "qk_l2_norm is not supported with MLA." | ||
|
|
||
| fuse_input_layernorm = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can fuse_input_layernorm just be an argument to this function? that seems a more consistent UX than adding environment variables for any adjustment to the spec.
|
|
||
| import os | ||
| # NOTE: These toggles are intentionally environment-driven for experimentation. | ||
| # They are expected to be replaced by explicit config options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace them now. We do not use environment variables to configure anything in mcore.
What does this PR do ?
add FUSE_QKV_DOWN_PROJ and FUSE_INPUT_LAYERNORM env to control the fusion.
It is ready for profiling, but still need some change to be merged.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.