Skip to content

Conversation

@megnvidia
Copy link
Contributor

@megnvidia megnvidia commented Jan 20, 2026

What does this PR do ?

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: meg miranda <mmiranda@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 20, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

…tall

Signed-off-by: meg miranda <mmiranda@nvidia.com>
…n(it is in the sglang), moved our quick start link after the news.

Signed-off-by: meg miranda <mmiranda@nvidia.com>
…>ecosystem libraries) to overview, merged a bit of my draft overview content from before. Overview needs some technical massage, I have some points wrong in my descriptions.

Signed-off-by: meg miranda <mmiranda@nvidia.com>
@Phlip79 Phlip79 added the docs-only documentation only (docs or docstrings) label Jan 21, 2026
…ility with doc team structure template

Signed-off-by: meg miranda <mmiranda@nvidia.com>
Signed-off-by: meg miranda <mmiranda@nvidia.com>
Signed-off-by: meg miranda <mmiranda@nvidia.com>
Signed-off-by: meg miranda <mmiranda@nvidia.com>
@megnvidia megnvidia marked this pull request as ready for review January 21, 2026 01:18
@ko3n1g ko3n1g requested a review from a team January 21, 2026 01:18
@Phlip79 Phlip79 self-requested a review January 22, 2026 22:26
@Phlip79 Phlip79 changed the title mmiranda edits to readme file Minimize README contents Jan 22, 2026
```
**Megatron-LM**: GitHub repository that includes Megatron-Core, as well as example training loops utilizing Megatron-Core.

**Megatron-Bridge**: a separate repository that is ideal for users who wish to train a Hugging Face model.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It serves as a powerful bridge, conversion, and verification layer between Hugging Face and Megatron Core.

**[Complete Installation Guide](#installation)** - Docker, pip variants (dev,lts,etc.), and system requirements
**NeMo RL**: library that streamlines and scales reinforcement learning, that leverages Megatron-Core.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Megatron-Core and Megatron-LM are open-source tools that are typically used together to train LLMs at scale across GPUs. Megatron-Core expands the capability of Megatron-LM. Megatron Bridge connects Megatron-Core and Megatron-LM to other popular training models, such as Hugging Face.


## Megatron-LM:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Megatron-LM:
## Megatron-LM

- End-to-end examples from data prep to evaluation
- Research-focused tools and utilities

## Megatron Core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the Megatron Core section before Megatron-LM


Megatron-Core is compatible with all NVIDIA Tensor Core GPUs and popular LLM architectures such as GPT, BERT, T5, and RETRO.

[![Megatron-Core Documentation](https://img.shields.io/badge/docs-latest-brightgreen.svg?style=flat)](https://docs.nvidia.com/Megatron-Core/developer-guide/latest/index.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix section titles to make them use ## instead of #. Also, can we remove colons from titles?

@Phlip79 Phlip79 requested review from sbhavani and removed request for a team January 22, 2026 22:55
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request docs-only documentation only (docs or docstrings) needs-follow-up Issue needs follow-up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants