-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Minimize README contents #3020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Minimize README contents #3020
Conversation
Signed-off-by: meg miranda <mmiranda@nvidia.com>
…tall Signed-off-by: meg miranda <mmiranda@nvidia.com>
…n(it is in the sglang), moved our quick start link after the news. Signed-off-by: meg miranda <mmiranda@nvidia.com>
…>ecosystem libraries) to overview, merged a bit of my draft overview content from before. Overview needs some technical massage, I have some points wrong in my descriptions. Signed-off-by: meg miranda <mmiranda@nvidia.com>
…ility with doc team structure template Signed-off-by: meg miranda <mmiranda@nvidia.com>
Signed-off-by: meg miranda <mmiranda@nvidia.com>
Signed-off-by: meg miranda <mmiranda@nvidia.com>
Signed-off-by: meg miranda <mmiranda@nvidia.com>
| ``` | ||
| **Megatron-LM**: GitHub repository that includes Megatron-Core, as well as example training loops utilizing Megatron-Core. | ||
|
|
||
| **Megatron-Bridge**: a separate repository that is ideal for users who wish to train a Hugging Face model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add link: https://github.com/NVIDIA-NeMo/Megatron-Bridge.
| It serves as a powerful bridge, conversion, and verification layer between Hugging Face and Megatron Core. | ||
|
|
||
| **→ [Complete Installation Guide](#installation)** - Docker, pip variants (dev,lts,etc.), and system requirements | ||
| **NeMo RL**: library that streamlines and scales reinforcement learning, that leverages Megatron-Core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add link: https://github.com/NVIDIA-NeMo/RL.
| Megatron-Core and Megatron-LM are open-source tools that are typically used together to train LLMs at scale across GPUs. Megatron-Core expands the capability of Megatron-LM. Megatron Bridge connects Megatron-Core and Megatron-LM to other popular training models, such as Hugging Face. | ||
|
|
||
|
|
||
| ## Megatron-LM: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Megatron-LM: | |
| ## Megatron-LM |
| - End-to-end examples from data prep to evaluation | ||
| - Research-focused tools and utilities | ||
|
|
||
| ## Megatron Core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the Megatron Core section before Megatron-LM
|
|
||
| Megatron-Core is compatible with all NVIDIA Tensor Core GPUs and popular LLM architectures such as GPT, BERT, T5, and RETRO. | ||
|
|
||
| [](https://docs.nvidia.com/Megatron-Core/developer-guide/latest/index.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix section titles to make them use ## instead of #. Also, can we remove colons from titles?
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.