Skip to content

[Bug] Eliminated trigger fires twice #1823

@antontimmermans

Description

@antontimmermans

Describe the bug

the Eliminated trigger seems to fire twice after it has been set in the previous round.

Although it doesn't break mechanics, it is not behaving as expected/specified.

Scenario

test scenario:
TriggerAndVariablesTist.zip

Steps to reproduce the behavior:

StartRound 1
Trigger: StartRound activates
variable #eliminated has value 0
variable #eliminatedprev has value 0
variable #eliminatedcomplete has value 0
-> in game menu select option : Set -> Investigator Eliminated
variable #eliminated has value 1
variable #eliminatedprev has value 0
variable #eliminatedcomplete has value 0

-> in game menu select option : End Turn
Trigger: EndInvestigatorTurn activates
Trigger: Mythos activates
Trigger: BeforeMonsterActivation activates
EndRound 1

Start round 2
Trigger: StartRound activates
variable #eliminated has value 1
variable #eliminatedprev has value 1
variable #eliminatedcomplete has value 0
-> in game menu select option : End Turn
Trigger: Eliminated activates
-> in game menu select option : End Turn
Trigger: EndInvestigatorTurn activates
variable #eliminated has value 1
variable #eliminatedprev has value 1
variable #eliminatedcomplete has value 1
Trigger: Mythos activates
Trigger: BeforeMonsterActivation activates
Trigger: Eliminated activates
EndRound 2

Start round 3
variable #eliminated has value 1
variable #eliminatedprev has value 1
variable #eliminatedcomplete has value 1

StartRound 1
Trigger: StartRound activates
variable #eliminated has value 0
variable #eliminatedprev has value 0
variable #eliminatedcomplete has value 0
-> in game menu select option : Set -> Investigator Eliminated
variable #eliminated has value 1
variable #eliminatedprev has value 0
variable #eliminatedcomplete has value 0

-> in game menu select option : End Turn
Trigger: EndInvestigatorTurn activates
Trigger: Mythos activates
Trigger: BeforeMonsterActivation activates
EndRound 1

Start round 2
Trigger: StartRound activates
variable #eliminated has value 1
variable #eliminatedprev has value 1
variable #eliminatedcomplete has value 0
-> in game menu select option : End Turn
Trigger: Eliminated activates
-> in game menu select option : End Turn
Trigger: EndInvestigatorTurn activates
variable #eliminated has value 1
variable #eliminatedprev has value 1

variable #eliminatedcomplete has value 1
Trigger: Mythos activates
Trigger: BeforeMonsterActivation activates
Trigger: Eliminated activates
EndRound 2

Start round 3
variable #eliminated has value 1
variable #eliminatedprev has value 1
variable #eliminatedcomplete has value 1

Expected behavior

It should fire only once, and alos the 2 times 'end turn' is weird.

However this only happens if the scenario creator didn't handle the death of an investigator properly.

I assume that the timing of the first Trigger is the correct timing. In that case no fix is needed and although it's weird behaviour (twice 'end trun'), it's only visible if the scenario writer makes a mistake.

LogFile

Screenshots

Valkyrie Version

Desktop

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions