Add filled contour map plotting capabilities#145
Add filled contour map plotting capabilities#145kevindougherty-noaa merged 4 commits intodevelopfrom
Conversation
kevindougherty-noaa
requested review from
CoryMartin-NOAA and
EdwardSafford-NOAA
|
The following tests and examples added produce this figure:
|
EdwardSafford-NOAA
left a comment
EdwardSafford-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me -- just had the one question on a variable name.
|
|
||
| def _map_filled_contour(self, plotobj, ax): | ||
|
|
||
| skipvars = ['plottype', 'longitude', 'latitude', 'data', |
There was a problem hiding this comment.
Just a question on the choice of skipvars as a name. Does it have a specific meaning in this context? I'm not super familiar with emcpy so I might be missing something.
There was a problem hiding this comment.
If I recall correctly, it's what keys in the dictionary to not pass to the underlying matplotlib plotting routine
There was a problem hiding this comment.
Yes, it means exactly what you think. In map_plot.py, there are variables that are added to python object so we need to skip certain ones that are not related to the kargs that are for plot related things themselves.
## Description This PR looks to add a missing need for Filled Contour Map plots and Gridded plots. Specifically attempting to solve the following issue: [here](#216 (comment)) ## Dependencies Waiting on the following PRs: - [x] waiting on [NOAA-EMC/emcpy/pull/145](NOAA-EMC/emcpy#145) --------- Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
3 participants
There is a need to plot filled contour maps for eva #216.
The following adds those needed capabilities to EMCPy so they can be used in eva.