Adds ShapeImage and ShapeIcon fields to display custom marker icons in the legend #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes shapeOverride field - shapeIcon will use mdi icons for the legend - shapeImage will use a URL to a .png or .svg for the legend
jtroberts
changed the title
- Color the shape icon rather than background - Removed triangle as a special case (apparently it was never handled)
tariqksoliman
requested changes
Apr 28, 2025
Member
tariqksoliman
left a comment
tariqksoliman
left a comment
There was a problem hiding this comment.
Minor change: could you support more possible file formats:
String(shape).toLowerCase().match(/\.(jpeg|jpg|gif|png|svg|webp)$/) != null
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proposed Changes
Issues
Testing