Skip to content

Twitter.js issue solved #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sushanth145 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Twitter.js issue solved #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 4 additions & 31 deletions dist/hello.all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! hellojs v1.20.0 - (c) 2012-2023 Andrew Dodson - MIT https://adodson.com/hello.js/LICENSE */
/*! hellojs v1.20.0 - (c) 2012-2025 Andrew Dodson - MIT https://adodson.com/hello.js/LICENSE */
// ES5 Object.create
if (!Object.create) {

Expand Down Expand Up @@ -5426,10 +5426,10 @@ if (typeof chrome === 'object' && typeof chrome.identity === 'object' && chrome.
return res;
}
},
xhr: function(p) {

// Rely on the proxy for non-GET requests.
return (p.method !== 'get');
xhr: function(p) {
// Always use the proxy to ensure OAuth signing on all requests (GET and others)
return true;
}
}
});
Expand Down Expand Up @@ -5485,33 +5485,6 @@ if (typeof chrome === 'object' && typeof chrome.identity === 'object' && chrome.
return Array.isArray(res) ? {data: res} : res;
}

/**
// The documentation says to define user in the request
// Although its not actually required.

var user_id;

function withUserId(callback){
if(user_id){
callback(user_id);
}
else{
hello.api('twitter:/me', function(o){
user_id = o.id;
callback(o.id);
});
}
}

function sign(url){
return function(p, callback){
withUserId(function(user_id){
callback(url+'?user_id='+user_id);
});
};
}
*/

})(hello);
// Vkontakte (vk.com)
(function(hello) {
Expand Down
3 changes: 1 addition & 2 deletions dist/hello.all.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/hello.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! hellojs v1.20.0 - (c) 2012-2023 Andrew Dodson - MIT https://adodson.com/hello.js/LICENSE */
/*! hellojs v1.20.0 - (c) 2012-2025 Andrew Dodson - MIT https://adodson.com/hello.js/LICENSE */
// ES5 Object.create
if (!Object.create) {

Expand Down
3 changes: 1 addition & 2 deletions dist/hello.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 3 additions & 30 deletions src/modules/twitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@
return res;
}
},
xhr: function(p) {

// Rely on the proxy for non-GET requests.
return (p.method !== 'get');
xhr: function(p) {
// Always use the proxy to ensure OAuth signing on all requests (GET and others)
return true;
}
}
});
Expand Down Expand Up @@ -192,31 +192,4 @@
return Array.isArray(res) ? {data: res} : res;
}

/**
// The documentation says to define user in the request
// Although its not actually required.

var user_id;

function withUserId(callback){
if(user_id){
callback(user_id);
}
else{
hello.api('twitter:/me', function(o){
user_id = o.id;
callback(o.id);
});
}
}

function sign(url){
return function(p, callback){
withUserId(function(user_id){
callback(url+'?user_id='+user_id);
});
};
}
*/

})(hello);