Skip to content

If ls_val is not given in argument, need to go through mmg option parser #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Algiane merged 2 commits into from
Apr 20, 2023
Merged

If ls_val is not given in argument, need to go through mmg option parser #89

Algiane merged 2 commits into from
Apr 20, 2023

Conversation

@laetitia-m
Copy link
Contributor

@laetitia-m laetitia-m commented Apr 18, 2023

If the value of the level was not given as arguments, ParMmg was failing to identify the solution file as the level-set file.
This fix append the mmg arguments into PMMG_parsar to be able to support this.
Tests were also added.

@Algiane Algiane added kind: enhancement enhancement to an existing feature part: I/O specific to I/Os part: ls discretization isovalue mode specificty labels Apr 20, 2023
@Algiane Algiane added this to the // level-set discretization milestone Apr 20, 2023
@Algiane
Copy link
Member

Algiane commented Apr 20, 2023

Thanks,
Note that the newly added tests are failing (since the previous branch merging).

@Algiane Algiane merged commit 27d486e into MmgTools:develop Apr 20, 2023
@laetitia-m laetitia-m deleted the feature/ls-options-arg-fix branch May 10, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind: enhancement enhancement to an existing feature part: I/O specific to I/Os part: ls discretization isovalue mode specificty

Projects

level-set discretization in parallel
Status: Done

Milestone

// level-set discretization

Development

Successfully merging this pull request may close these issues.

2 participants

@laetitia-m @Algiane