Feature/find mmg private headers #80
Conversation
This commit also includes some of the proposition of @prudhomme to use Mmg and ParMmg as submodules of a super project.
Start also to fix issue when VTK is found but vtkMPIController.h header is not (doesn't work for now).
Algiane
added
part: compilation
…tk in Mmg compilation.
| #define _LIBPARMMGTYPES_H | ||
|
|
||
| #include "mmg/mmg3d/libmmgtypes.h" | ||
| #include "libmmgtypes.h" |
There was a problem hiding this comment.
| #include "libmmgtypes.h" | |
| #include "mmg/common/libmmgtypes.h" |
That's the single diff I have to apply to make everything work, last I checked.
|
Thanks a lot for your responsiveness and for your help. As the last issue is in ParMmg and not Mmg I will merge the current PR and solve the issue of header inclusion in ParMmg later (that I still don't understand because Best Regards, |
|
No problem, we can iterate once the Mmg branch is merged. Worst case scenario, you can't wrap things up on the ParMmg side, then I'll just need to keep the ParMmg fork. At least I'll be able to redirect the trafic on the official Mmg repository. |
|
PR will be merged to follow the merge of the PR MmgTools/mmg#187 of Mmg but we may still have some header inclusions to fix in ParMmg. |
Find Mmg private headers
Update ParMmg to find Mmg headers after commit
f3c20cb1b8e638208880efc9of Mmg.Linked to:
It also include some of the propositions of improvement of @prudhomm to use ParMmg as submodule (not all of them for now).