Skip to content

Feature/compilation simplification #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Algiane merged 15 commits into from
Feb 17, 2023
Merged

Feature/compilation simplification #69

Algiane merged 15 commits into from
Feb 17, 2023

Conversation

@Algiane
Copy link
Member

@Algiane Algiane commented Dec 1, 2022 •
edited
Loading

⚠️ NOT TO MERGE RIGHT NOW ⚠️

🚧 Need to be fixed and reviewed (maybe implementation has to be completed...) 🚧
PR is done in order to link this work to GitHub projects

Algiane and others added 10 commits October 30, 2020 19:06
@Algiane Algiane added part: compilation compilation related kind: cleanup should be clean kind: enhancement enhancement to an existing feature part: cmake cmake part priority: medium linked to strong improvements or to a medium-term deadline labels Dec 1, 2022
@Algiane Algiane mentioned this pull request Dec 5, 2022
Closed
@Algiane
Copy link
Member Author

Algiane commented Feb 17, 2023

Checked and manually merged with develop the 17/02/23:

  • things (such as removal of MMG_BUILDDIR and compliant setting of STATIC or SHARED libraries compilation) have been done in double between this branch and the develop one;
  • the Mmg tarball has been removed (to avoid manual maintenance)
  • it has been chosen to keep the LIBPARMMG_STATIC/SHARED variables (versus keeping only the BUILD_SHARED/STATIC_LIBS CMake variable): the only reason is to keep retrocompatibility with old options

@Algiane Algiane merged commit 131951a into develop Feb 17, 2023
@Algiane Algiane deleted the feature/compilation-simplification branch August 21, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind: cleanup should be clean kind: enhancement enhancement to an existing feature part: cmake cmake part part: compilation compilation related priority: medium linked to strong improvements or to a medium-term deadline

Projects

More user-friendly software
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Algiane @lcirrottola