Abort if nosplit option used in multimat mode
#108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Algiane
added
kind: enhancement
Algiane
reviewed
Apr 4, 2024
src/ls_pmmg.c
Outdated
| ref = mat->ref; | ||
| refint = mat->rin; | ||
| refext = mat->rex; | ||
| if ( (ref == refint) & (ref == refext) ) { |
src/ls_pmmg.c
Outdated
Comment on lines
120
to
123
| if ( parmesh->info.imprim > PMMG_VERB_VERSION ) { | ||
| fprintf(stdout,"\n -- WARNING: The option `nosplit` in multimat is not supported yet.\n\n\n"); | ||
| PMMG_RETURN_AND_FREE( parmesh, PMMG_LOWFAILURE ); | ||
| } |
Member
There was a problem hiding this comment.
As the option is not supported, you always want to stop the process so I would always print an error message and exit, not only in case of PMMG_VERB_VERSION verbosity:
fprintf(stderr,"\n -- ERROR: The option `nosplit` in multimat is not supported yet.\n\n\n");
PMMG_RETURN_AND_FREE( parmesh, PMMG_LOWFAILURE );
Contributor
Author
There was a problem hiding this comment.
Done + modify return to be 0 instead of PMMG_RETURN_AND_FREE (here and elsewhere in the file too).
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now (until the overlap), the multimat mode does not support the
nosplitoption in*.mmg3dfile.This PR raises a warning and stops the code if the option
nosplitis used.