Copy mesh information of local parameters or LS reference (multimat) #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the mesh. memcopy was copying the pointer address only and was leading to double free error
…d par arrays when we have a *mmg3d input file for local parameters or LS references (multimat)
…k_infos to take into account mesh->info.invmat data correctly
… PMMG_mpiunpack_infos function with ier_mesh != 1
Algiane
added
kind: bug
Algiane
approved these changes
Feb 26, 2024
Member
Algiane
left a comment
Algiane
left a comment
There was a problem hiding this comment.
It is all good for me,
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memcopybyPMMG_copy_mmgInfofunction to copy mesh information when merge the mesh inPMMG_mergeParmesh_rcvParMeshes.memcopywas copying the pointer address only and was leading to double free error.PMMG_copy_mmgInfoto now update correctly the copy ofmesh->info.mat,mesh->info.invmat.lookupandmesh->info.pararrays when we have a*mmg3dinput file (local parameters or LS multimat references).PMMG_mpisizeof_filenames,PMMG_mpipack_infosandPMMG_mpiunpack_infosto take into accountmesh->info.invmatdata correctly as the structureMMG5_InvMatwas added to mmg after the initial creation of this function in ParMmg.*mmg3dis read correctly for centralized/distributed input and centralized/distributed output + update gitlab tag to point towards the latest up-to-datetestparmmgcommit.