Feature/fix edge length #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Calls the suitable function in PMMG_computePrilen when an aniso metric
is provided with a specific metric storage at ridges (metRidTyp==1)
- Check if metric is allocated before computing the edge lengths (to avoid memory errors)
but inside the `MMG3D|PMMG_computePrilen` functions to be able to differentiate the cases where:
- computePrilen fails due to memory error
- We have a metric on at least one MPI proc so we can compute the edge lengths
- We don't have any metric (and we cannot compute the edge length histo). In this case and
with a centralized mesh on 1 proc and -v 10 verbosity, we were previously printing infinit edge lengths.
It makes the PMMG_prilen function callable everywhere in the software.
Algiane
added
kind: bug
…subscribe command line option support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a suitable handling of edge length histogram. Now we differentiate the cases where:
It also fixes an error in the computation of edge lengths for an anisotropic metric with ridge storage.