[Cluster] Port autoselection 2/2: Port autoselection#312
Merged
Conversation
…ter/auto-port-selecting
christopherfish
changed the title
christopherfish
added
the
mindtrace-cluster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR, one can omit the
worker_urlargument toCluster.launch_worker()andNode.launch_worker()(the former of which calls the latter). In this case, the Worker will be launched with the same hostname as the Node in question, with a port chosen from a range specified inMINDTRACE_CLUSTER::WORKER_PORTS_RANGE.The resulting Worker URL is now returned by both methods, along with the Worker ID and name.