Skip to content

Refactor settings SharedPreferences access #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2025
Merged

Refactor settings SharedPreferences access #66

merged 1 commit into from
Aug 31, 2025

Conversation

MihaiCristianCondrea
Copy link
Owner

Summary

  • Replace broad getSharedPreferences with specific methods like getDarkMode, setConsentAccepted and change registration API
  • Update SettingsActivity and SettingsViewModel to use dedicated preference accessors
  • Provide domain use cases and Dagger bindings for the new preference APIs

Testing

  • ./gradlew test (fails: SDK location not found)

https://chatgpt.com/codex/tasks/task_e_68b43f3db5b8832db54c98d1cf77f0c4

@MihaiCristianCondrea MihaiCristianCondrea merged commit e3c3d01 into main Aug 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MihaiCristianCondrea